version above 16 december 2023 for blender 3.6 not export emission day night cycle extension

PGSimulation commented 6 months ago

Current Behavior

    ],
    "materials":[
        {
            "emissiveFactor":[
                0.5,
                0.5,
                0.5
            ],
            "emissiveTexture":{
                "index":0
            },
            "name":"MaterialName",
            "normalTexture":{
                "index":1
            },
            "occlusionTexture":{
                "index":2
            },
            "pbrMetallicRoughness":{
                "baseColorTexture":{
                    "index":3
                },
                "metallicRoughnessTexture":{
                    "index":2
                }
            }
        }
    ],

Expected Behavior

    "materials":[
        {
            "emissiveFactor":[
                1,
                1,
                1
            ],
            "emissiveTexture":{
                "index":0
            },
            "extensions":{
                "ASOBO_material_day_night_switch":{}
            },
            "extras":{},
            "name":"MaterialName",
            "normalTexture":{
                "index":1
            },
            "occlusionTexture":{
                "index":2
            },
            "pbrMetallicRoughness":{
                "baseColorFactor":[
                    1,
                    1,
                    1,
                    1
                ],
                "baseColorTexture":{
                    "index":3
                },
                "metallicRoughnessTexture":{
                    "index":2
                }
            }
        }
    ],

Steps To Reproduce

checkout commit from 16 december 2023 in git app for blender 3.6 branch and try export material with standard shader with emission pbr map, color 1.0 and day night cycle. and then checkout commit from 20 december or newer and export the same material.

            "extensions":{
                "ASOBO_material_day_night_switch":{}
            },
            "extras":{},

Dissapear and day night cycle for emission not working obraz obraz

Environment

- OS: Windows 10
- Blender: 3.6.5
- glTF-Blender-IO-MSFS: 
Working: 1, 6, 2, 17 aef555a - Update for BaseColor deleted if BaseColor texture
Not Working version or above: 1, 6, 2, 181299bf9 - Bug fix BaseColor checks

Anything else?

No response

ronh991 commented 6 months ago

Thank you for your report. How are you getting my code for use? Do you need a io_scene_gltf2_msfs.zip file or are you downloading my git project? io_scene_gltf2_msfs_for36.zip

PGSimulation commented 6 months ago

Thank you for your report. How are you getting my code for use? Do you need a io_scene_gltf2_msfs.zip file or are you downloading my git project? io_scene_gltf2_msfs_for36.zip

I download a specific commit from the "Fork" app but also sometimes the latest from branch 3.6 from the github site as a zip As newest zip: https://github.com/ronh991/glTF-Blender-IO-MSFS/tree/3.6-Update Or: https://github.com/ronh991/glTF-Blender-IO-MSFS/tree/aef555ab090de3ea04adb31dd94b0799f4716f7e

ronh991 commented 6 months ago

I would appreciate if you could test and report back if I have fixed this issue. So I can push this fix to 4.0 Update

PGSimulation commented 6 months ago

I would appreciate if you could test and report back if I have fixed this issue. So I can push this fix to 4.0 Update

Yes. ae41dbe works properly.

ronh991 commented 6 months ago

Issue has been resolved - closing

ronh991 / glTF-Blender-IO-MSFS