ronin-rb / ronin-app

A local web interface for Ronin.

https://ronin-rb.dev

GNU Affero General Public License v3.0

26 stars 8 forks source link

Add edit functionality for notes #101

Open AI-Mozi opened 7 months ago

AI-Mozi commented 7 months ago

58

AI-Mozi commented 7 months ago

@postmodern take a look at it please and let me know if you like it or what would you change. Code is not fully completed, I'll have to "refactor" it a bit later.

postmodern commented 7 months ago

Noticed that noteId is used a lot in multiple id elements. I wonder if we could use data attributes for that? Or have one query to find the outer most div with the noteId, and then sub-select the specific elements within the div based on class or element type.

postmodern commented 7 months ago

Oooh the JavaScript asset is for the icons. For SVG icons just download the desired icon files and put them into public/images/. Previously I would just do a Google Images search for "SVG edit icon" and filter by Creative Commons. I recently discovered iconduck.com which is a Free and Open Source collection of icons, and offers SVG downloads. We should probably just use individual icons from them.

postmodern commented 7 months ago

Doing a visual inspection, I think the grey text on black background for the comment header is hard to see in bright-mode. I'd use white text on a black background, or at least a brighter shade of grey. localhost_1337_db_host_names_1 (1)

postmodern commented 7 months ago

It also appears that the Delete doesn't remove the comment div immediately. Edit works perfectly thought.