Closed Sweetdevil144 closed 11 months ago
Sure. On it !
@postmodern I have a couply of ideas which we can go through:
required
keyword to all the forms. .label.is-required:hover::after {
content: ' Required';
font-size: 1em;
vertical-align: baseline;
position: absolute;
background-color: #f0f0f0;
color: black;
border: 1px solid #ddd;
padding: 2px 4px;
z-index: 1000;
/* Other styling as needed */
}
@Sweetdevil144 let's stay within scope of this issue and just add the red asterisks. Add the required
class to the fields which are required by the validations; these are usually the first few fields of the form. This will help users understand which fields are required, before even submitting the form.
If you look at the forms in views/
, you will notice that each form field checks for validation errors and renders the form field with the is-danger
Bulma CSS class which already highlights it red. Bulma.
Check it now ! This is how the form looks like now !
Random idea, what if you did .control.is-required label::after
to put the asterisk behind the <label>
, but only on div.control
elements with is-required
on them? That way is-required
gets put on the outer <div>
instead of the inner <label>
.
Present view of site. I guess this should do the work. I only kept an astrisk on select in Import File
option besauce that signified both fields. It looked really weired with one dot Over Nmap and another dot adjacent to it.
Random idea, what if you did
.control.is-required label::after
to put the asterisk behind the<label>
, but only ondiv.control
elements withis-required
on them? That wayis-required
gets put on the outer<div>
instead of the inner<label>
.
That way the astrisk would appear above the either before the label or at the end of our complete div. I mean, pseudo class after applies it to end of our closing outer
div.
Also, I really think we should work more on our stylings. For example, the Advanced
button looks wierd here. I think the same is with issue #49.
Present view :
The CSS doesn't have to be fancy, it just has to satisfy the requirements of the issue. We can always improve the CSS later.
This is how it appears on my browser. I was already utilizing hard tabs but idk why it shows 4 spaces in git
Hacktoberfest 2023 is now over! Congratulations on successfully submitting a PR to Ronin. As mentioned in the blog post, you are now eligible for free Ronin stickers! In order to claim your free stickers, please join the Ronin Discord server, and DM me the following information:
The stickers will then be mailed in a regular flat-rate envelope, from the US, without tracking. Note, it may take up to one month for International mail to arrive.
Required to fix #31 . Just a confirmation @postmodern . Does this work? I think we need to add a required class to forms such as
views/repos/install.erb
orviews/repos/show.erb
too. Getting issues to set-up ronin locally. I'm on discord too.