Closed AI-Mozi closed 9 months ago
You are correct. It should either be changed to masscan_file_to_csv(masscan_file,*output)
to cause the nil
value to be omitted, or change output=nil
to output=String.new
to match masscan_file_to_csv
.
Looking at ronin-nmap/lib/ronin/nmap/converters/csv.rb
, it uses output=String.new
, so I vote for that option to remain consistent.
Fixed by #15.
In
Converters::CSV.convert
output
argument will be set tonil
if we wont specify it. Then it will callmasscan_file_to_csv(mascan_file, nil
) somasscan_file_to_csv
'soutput
argument default value won't be applied and<<
will be called on Nil.I think we should change default value in
.convert
fromnil
toString.new