search

ronin-rb / ronin-rb.github.io

The ronin-rb.dev website
https://ronin-rb.dev
GNU General Public License v3.0
26 stars 21 forks source link

Multiple Broken links on the documentation website #48

Closed Smartmind12 closed 1 year ago

Smartmind12 commented 1 year ago

During page navigation there are multiple instances in which an error to the next or linked page arises as shown in the screenshot.

I would be sharing a pull request to mitigate the issue and make the website more efficient.

Screenshot 2023-10-02 at 7 18 08 PM

sahil9001 commented 1 year ago

Assign me this issue please, would like to work on it

Smartmind12 commented 1 year ago

Assign me this issue please, would like to work on it

@sahil9001 I myself am waiting for it to be assigned to me so that j can work on it . kindly take up another issue!

sahil9001 commented 1 year ago

No worries, you can take up this one.

postmodern commented 1 year ago

@sahil9001 @Smartmind12 unfortunately I am not assigning issues to new contributors. In the past when I have done that people have disappeared and the issues have remained open. Please just submit a PR.

postmodern commented 1 year ago

@Smartmind12 also please submit individual PRs to fix or add things, instead of submitting one giant PR that changes and adds multiple things. This makes it easier to review them or request changes.

Smartmind12 commented 1 year ago

@Smartmind12 also please submit individual PRs to fix or add things, instead of submitting one giant PR that changes and adds multiple things. This makes it easier to review them or request changes.

Sure got it … will do the needful!

postmodern commented 1 year ago

@Smartmind12 can this be closed now? All of your PRs has been merged and I fixed a few broken links as well. Are there more broken links?

Smartmind12 commented 1 year ago

@Smartmind12 can this be closed now? All of your PRs has been merged and I fixed a few broken links as well. Are there more broken links?

Yes I have gone through the same and all links work well ...we can close this issue now!

Smartmind12 commented 1 year ago

Closing issue #48 as solved by #50 to #56