search

ronin-rb / ronin-rb.github.io

The ronin-rb.dev website
https://ronin-rb.dev
GNU General Public License v3.0
25 stars 20 forks source link

Change the cursor to pointer #61

Closed CharithaCS closed 11 months ago

CharithaCS commented 11 months ago

The cursor needs to turn to a pointer when hovering on the dark mode icon in the home page header. Please review the changes. Thanks :)

Reference:2023-10-14 16_56_26-Ronin and 5 more pages - Personal - Microsoft​ Edge

postmodern commented 11 months ago

Is your cursor entirely black? What OS/browser are you using? On Chrome on Fedora Linux the cursor is black with a white border, so it shows up in dark-mode.

Also, screenshots will not show your cursor by default.

NilanjanPramanik commented 11 months ago

Hey I want to work on this issue can i work?

postmodern commented 11 months ago

@NilanjanPramanik already submitted a PR, but I'm not sure what the actual issue is here.

postmodern commented 11 months ago

Ooooh, I now understand what you mean. The cursor is not changing to the "pointing finger" style of cursor used for links.

postmodern commented 11 months ago

Closed by PR #62.

CharithaCS commented 11 months ago

Is your cursor entirely black? What OS/browser are you using? On Chrome on Fedora Linux the cursor is black with a white border, so it shows up in dark-mode.

Also, screenshots will not show your cursor by default.

I was specifically referring to the pointer finger icon as you mentioned in the other comment. I apologize for any confusion that has resulted due to this. I should have been more clear about that.