Open postmodern opened 10 months ago
Appears there's similar code in lib/ronin/recon/builtin/web/dir_enum.rb
. Could extract that code into a Mixin and helper method.
https://github.com/ronin-rb/ronin-recon/blob/92b2623eda791e81efe2623fc33fdb834d4aa5bd/lib/ronin/recon/builtin/web/dir_enum.rb#L93-L110
Should this new Mixin be included in CertSh
and DirEnum
classes or somewhere higher?
Also should it catch Errno::ETIMEDOUT
or just StandardError
?
Or should we include it just in CertSh
?
@AI-Mozi that is a good question. I would say only include it where we are currently needing to handle network timeouts and retries.
It appears that
Async::HTTP::Internet.instance
can raise anErrno::ETIMEDOUT
exception when the connection to the HTTP server times out. We should decide whether to ignore timeouts, or add a helper method that can retry the given block possibly with asleep(1)
delay and incremental counter. Such a helper method could be provided by aRonin::Recon::Mixins::Retry
mixin module.Pseudocode