Closed zzJZzz closed 1 month ago
@zzJZzz when you first edited the file it appears that your editor or something automatically changed the YAML schema of the entire file:
- :url: https://github.com/urbanadventurer/WhatWeb/blob/master/plugin-development/alexa-top-1000.txt
- :summary: The Alexa Top 1000 domain names.
- :categories:
- - dns
- - domains
+ url: https://github.com/urbanadventurer/WhatWeb/blob/master/plugin-development/alexa-top-1000.txt
+ summary: The Alexa Top 1000 domain names.
+ categories:
+ - dns
+ - domains
...
The YAML schema must use Symbol keys (ex :foo: ...
) to reduce memory consumption.
Probably one of my code formatters..ok I can fix this. Apologies for missing it.
I submitted some other suggestions. I think because the first commit accidentally changed the format of the wordlists.yml
file, the PR should be redone and resubmitted.
Details
Testing
I also ran the rspec for the file and 5 green passing tests.