search

roninoss / create-expo-stack

CLI tool to initialize a React Native application with Expo. Provides options to include Typescript, file-based routing via Expo Router, configuration based routing via pure React Navigation, styling via Nativewind, Restyle, Unistyles, StyleSheets, or Tamagui, and/or backend as a service such as Firebase and Supabase.
https://rn.new
MIT License
1.38k stars 77 forks source link

`ButtonProps` type is not imported in `/components/Button.tsx` #247

Closed FatahChan closed 5 months ago

FatahChan commented 5 months ago

Issue tracker is ONLY used for reporting bugs. New features should be discussed on our discord, in the #cli channel.

ButtonProps type is not imported in /components/Button.tsx

Expected Behavior

ButtonProps type should be imported

Current Behavior

ButtonProps type is not imported

Possible Solution

replace

import { Text, TouchableOpacity } from 'react-native';

with

import { ButtonProps, Text, TouchableOpacity } from 'react-native';

Steps to Reproduce

  1. run bun create expo-stack vidcorns --expo-router --nativewind --bun --supabase --import-alias --tabs
  2. check /components/Button.tsx
  3. ButtonProps is not imported

Context (Environment)

Just created the app using bun create expo-stack vidcorns --expo-router --nativewind --bun --supabase --import-alias --tabs checked the components and noticed missing import

Detailed Description

ButtonProps type is not imported in /components/Button.tsx

Possible Implementation

import { ButtonProps, Text, TouchableOpacity } from 'react-native';

FatahChan commented 5 months ago

Seems the issue was resolve in this commit

https://github.com/danstepanov/create-expo-stack/commit/11b6cc4d12a8018f376c1782301eb8768fd798f3

but has not been released yet

danstepanov commented 5 months ago

@FatahChan issue resolved in v2.6.5 of create-expo-stack