search

roninoss / create-expo-stack

CLI tool to initialize a React Native application with Expo. Provides options to include Typescript, file-based routing via Expo Router, configuration based routing via pure React Navigation, styling via Nativewind, Restyle, Unistyles, StyleSheets, or Tamagui, and/or backend as a service such as Firebase and Supabase.
https://rn.new
MIT License
1.58k stars 85 forks source link

[cli] chore: remove url polyfill #349

Closed imranbarbhuiya closed 4 months ago

imranbarbhuiya commented 4 months ago

Description

This pr removes the URL polyfill as it's built-in in expo now

Related Issue

Motivation and Context

Check https://docs.expo.dev/versions/latest/sdk/url/ for more info

How Has This Been Tested?

Screenshots (if appropriate):

dannyhw commented 4 months ago

is this built into to expo or is it in expo router? I thought it was added with the router

imranbarbhuiya commented 4 months ago

Their docs say

This API is part of the expo package

I haven't tried it without expo-router but seems like it's an expo feature and not expo-router

dannyhw commented 4 months ago

ok thanks for clarifying 👍

danstepanov commented 4 months ago

@dannyhw if you're good with this, we can test using the canary version?

dannyhw commented 4 months ago

Yeah sounds good. This looks fine to me.