roninoss / rn-primitives

Style-agnostic, accessible React Native components for iOS, Android, and Web
https://rnprimitives.com
MIT License
427 stars 12 forks source link

fix(#17): web select overlay to be hidden by default #21

Closed mrzachnugent closed 4 months ago

mrzachnugent commented 4 months ago

Description

In the web version on the select, radix-ui needs to the content of portal to render the item selected. The overlay component, in this case, is required on native so it is added on web to match. For that reason, the overlay which is in the portal is not handled by radix-ui and is shown by default. This PR shows the overlay when the select is open only and bumps the version.

After merging

The @rn-primitives/select package will need to be released on NPM

Screenshots

Tested both Web and iOS, overlay works as intended.

Screenshot 2024-07-20 at 3 23 37 PM Screenshot 2024-07-20 at 3 23 47 PM
vercel[bot] commented 4 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rn-primitives ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 20, 2024 7:38pm