ronisbr / doom-nano-themes

A light and dark themes for Doom Emacs based on N Λ N O Themes
GNU General Public License v3.0
96 stars 3 forks source link

Best practice for updating #7

Open LukasCBossert opened 1 year ago

LukasCBossert commented 1 year ago

While the doom-nano-modeline-package is updated automatically using doom upgrade, what is a best practice for updating this repository? Currently I would use the content of https://raw.githubusercontent.com/ronisbr/doom-nano-themes/main/doom-nano-dark-theme.el and overwrite my locally stored files. Probably I could also have this repo in the config-folder and use git pull.... But is there a better/automatic approach updating the files?

ronisbr commented 1 year ago

Hi @LukasCBossert ! That is a good question, and I do not have a good answer :(

The files must be in ./.doom.d/themes/. Maybe you can use doom upgrade but symlink the files to that directory? Notice that everything will be way easier when the theme is good enough to be submitted to doom-themes repository.

If anyone has a better idea how to automate the upgrade process, please, let me know!

LukasCBossert commented 1 year ago

Hi @ronisbr , thanks for the quick answer.

Stupid question: Why is the same approach not working for the themes like for the modeline:

(package! doom-nano-modeline
  :recipe (:host github
  :repo "ronisbr/doom-nano-modeline"))

(in the packages.el-file).

ronisbr commented 1 year ago

That's not stupid at all!

The problem seems with how doom-themes is built. For some reason, the themes must be inside .doom.d/themes, otherwise they did not work. Even if you load the file manually, I could not make it work. However, I have very little experience and maybe someone can help us to improve the installation process :)

LukasCBossert commented 1 year ago

ok, sounds logically. Yeah, I am (also) a not so experienced but enthusiastic user. Hopefully there is someday the integration of this theme in the doom-themes..... or @hlissner will be able to include nano-emacs into Doom entirely (cf. https://github.com/doomemacs/doomemacs/issues/4413)