ronivay / XenOrchestraInstallerUpdater

Xen Orchestra install/update script
GNU General Public License v3.0
1.16k stars 189 forks source link

add Oracle Linux 8 support #108

Closed copyrights closed 2 years ago

copyrights commented 2 years ago

This adds support for Oracle Linux 8.

I used vagrant for testing.

Vagrantfile:

# -*- mode: ruby -*-
# vi: set ft=ruby :

Vagrant.configure("2") do |config|

  config.vm.box = "generic/oracle8"

  config.vm.network "forwarded_port", guest: 80, host: 20080

  config.vm.provider "virtualbox" do |vb|
    vb.memory = "4096"
    vb.cpus = 2
  end

  config.vm.provision "shell", inline: <<-SHELL
    yum install -y git
    git clone -b eol8 https://github.com/copyrights/XenOrchestraInstallerUpdater.git
    cd XenOrchestraInstallerUpdater
    ./xo-install.sh --install
    firewall-cmd --add-service http
  SHELL
end
ronivay commented 2 years ago

Hi,

Thanks for the effort. Unfortunately i'm not too excited to expand the list of supported OS's. There is already quite a few popular ones which should be more than enough. Any specific reason why Oracle Linux should be used instead, other than personal preference?

copyrights commented 2 years ago

Since CentOS Project announced shifting focus to CentOS Stream a lot stability concerned businesses were looking for a successor. Rocky Linux and AlmaLinux sure are, but Oracle Linux has the advantage of being around for a while and have a solid business with Oracle Linux. I have no data on it, but I would guess most conservative companies will likely choose OEL over the other alternatives...or choose RHEL ;-)

ronivay commented 2 years ago

Kind of answer i was expecting. One very important aspect to note is that this script is definitely not intended to be used in business critical environments. Official XOA is the right option in those cases.

That being said, i see it that 3 different RHEL based distros is plenty. Since this would cause more testing work and i haven't seen any requests before for Oracle Linux support, i'll skip merging this at this time.

As said, i appreciate the effort and contribution anyway and will definitely revisit this if there's more requests later to add support for Oracle Linux

copyrights commented 2 years ago

understandable. I was just playing around with OEL and XO and through I share my results. But keeping the test base small is a very valid point. And a :heart: from @olivierlambert is definitely worth closing the PR :wink: