search

ronivay / XenOrchestraInstallerUpdater

Xen Orchestra install/update script
GNU General Public License v3.0
1.16k stars 189 forks source link

Fix detection of latest tagged release #119

Closed shaneallgeier closed 2 years ago

shaneallgeier commented 2 years ago

The ability to find the latest tagged release is broken due to the runcmd function not preserving the current directory.

I could've used local TAG=$(runcmd_stdout "cd $INSTALLDIR/xo-builds/xen-orchestra-$TIME && git describe --tags '$(cd $INSTALLDIR/xo-builds/xen-orchestra-$TIME && git rev-list --tags --max-count=1)'") instead but it seemed a little too long.

ronivay commented 2 years ago

Cheers. This feature has actually been useless for quite some time. XO repository hasn't had new tagged releases after 2019. Should probably be removed instead.

shaneallgeier commented 2 years ago

I was wondering about that. Do they just not tag their new versions anymore?

ronivay commented 2 years ago

https://github.com/ronivay/XenOrchestraInstallerUpdater/issues/117#issuecomment-1100875398

This sums it up quite well (from recent feature request).

ronivay commented 2 years ago

so yeah, as this feature is quite obsolete now, i've instead removed it in https://github.com/ronivay/XenOrchestraInstallerUpdater/commit/2f276eb80fe17d94921b7cdc12cacecc3ee7f3d7 and will be closing this without merge. thanks for the effort though :)