search

ronivay / XenOrchestraInstallerUpdater

Xen Orchestra install/update script
GNU General Public License v3.0
1.24k stars 193 forks source link

Don't force xo-proxy port to 443 #235

Open andrew64k opened 6 months ago

andrew64k commented 6 months ago

OS Version: Debian 11 Node.js version: v18.20.2 Yarn version: 1.22.19

Server specs 2xCPU, 4G RAM

Issue I have the port for proxy config is set to 4443 in both xo-install.cfg and config.toml Install script xo-install.sh forces port to 443 for service start check if xo-proxy is used.

    if [[ "$XO_SVC" == "xo-proxy" ]]; then
        local PORT="443"
    fi

Installation logfile

[info] Starting xo-proxy...
 waiting for port to be open
 waiting for port to be open
 waiting for port to be open
 waiting for port to be open
 waiting for port to be open
 waiting for port to be open
ronivay commented 6 months ago

Hi,

Yes this is on purpose. When adding proxy to XO, there is no option to define the port and it will always use 443.

andrew64k commented 6 months ago

Changing the port works just fine. Both on the proxy side and the XO side. I'm using port 4443 now.

ronivay commented 6 months ago

Okay, then it must've changed. Please explain how the proxy was added with a custom port to XO and i might be able to change the logic.

andrew64k commented 6 months ago

On XO, for the Proxies page the Address is just remote.site.com:4443. Same idea for the Servers setting HTTP proxy URL is https://YourKey@remote.site.com:4443/

In your xo-install.cfg I just use PORT="4443" and it ends up in .config/xo-proxy/config.toml as port = 4443

ronivay commented 6 months ago

Okay, i need to give this a shot. For the XO proxy, it used to be hard coded to port 443 and was not configurable when adding proxy, hence the installation here forced it to port 443 too.

github-actions[bot] commented 6 months ago

This issue has been open for 14 days without activity. It will be closed in 5 days if not updated