Closed dsiminiuk closed 3 years ago
Hi,
yeah that’s expected behaviour that installation isn’t cleaned if it fails in startup phase since it’s most likely something else than failed build at that point. Also enabling service is skipped at that point so it doesn’t start after reboot.
It seems to be simply a check error when looking specific line from service log. I wonder why this doesn’t happen every time. But that line indeed isn’t there according to logs. Need to do little testing.
Looks like you've manually changed the config listen line to 0.0.0.0, so the check fails, even though service started fine. Indeed something to be fixed, but haven't had reported issues with that check before.
Changed the logic a bit and now it should hit no matter what the listen address is.
@ronivay
In what file would is this listen configuration item? I don't see it anywhere nor do I recall ever setting it.
In any case, I downloaded the latest version of the script and it ran fine.
[info] Starting xo-server...
waiting for port to be open
WebUI started in port 80. Make sure you have firewall rules in place to allow access.
[info] Update successful. Enabling xo-server service to start on reboot
Thanks!
Would it be possible to put a version number/release date in the comment header of the script so I can see what I have as compared to the raw version hosted here?
Couple possible places. This script adds config to users (which you've defined in xo-install.cfg) home directory, which by default is /root/.config/xo-server/config.toml
. Xen Orchestra will prefer this config file, but will also read settings from /etc/xo-server/config.toml
if one has added this by hand. Settings in latter will only have effect if they aren't set in the one inside users home directory.
There is a setting under [[http.listen]]
called hostname
which is commented out by default which means it'll listen all addresses. Only way i could reproduce the same you had, was by setting this to 0.0.0.0. Even disabling IPv6 completely still caused the log to show the default http://[::]:80
instead of http://0.0.0.0:80
I've had some ideas about adding version numbers to script. I'll look into it soon.
I do have a file here /root/.config/xo-server/config.toml but there is no mention of the term "listen" or any IP addresses.
FIle /etc/xo-server/config.toml doesn't exist.
However, I have several other copies outside of the /etc/xo/xo-builds directory...
In /etc/xo/xo-src/xen-orchestra/packages/xo-server/config.toml there is
[[http.listen]]
port = 80
# These options are applied to all listen entries.
[http.listenOptions]
In /etc/xo/xo-src/xen-orchestra/packages/xo-server-test/config.toml there is no mention of listen or an IP address.
In /etc/xo/xo-src/xen-orchestra/@xen-orchestra/proxy/config.toml I see
[http.listen.https]
And I have never looked at these files before, much less modified them.
I did disable IPv6 in the grub command line with "ipv6.disable=1".
When was that /root/.config/xo-server/config.toml last modified? Assuming CONFIGUPDATE variable is set to true in xo-install.cfg, it should be rewritten during every update. It should definitely have http.listen section since that's copied directly from xen orchestra sources sample file and edited so that port, ssl-certificate etc match what is configured in xo-install.cfg.
All other files you found are default configs which shouldn't be edited by hand anyway and don't have effect across different installations present.
It could very well be the ipv6 disable. Just didn't behave the same with my test Debian 10 VM. Anyway nothing wrong having only IPv4 address as listener and now script should figure out that service started no matter what the listen address is.
Timestamp...
-rw-r--r-- 1 root root 4760 Mar 18 17:01 config.toml
In xo-install.cfg
CONFIGUPDATE="true"
It built successfully last time so no issues now. I was just trying to get to the root of "Looks like you've manually changed the config", because I hadn't. :)
Yeah my bad for assuming you had. Should be okay now what comes to checking if service started or not.
OS Version: Ubuntu 20.04.2 LTS Node.js version: v15.10.0 Yarn version: 1.22.5 Server specs: 2 vCPUs 4GB
Issue Updates appear to complete but detects a problem which. Sometimes a reboot will enable the service and other times not and then the installation needs to be reverted.
Because the script doesn't finish, the /etc/xo/xo-builds directory is not cleansed and it eventually fills the disk.
Console output during update...
However, service appears active.
If the WebUI is left open during the update and then refreshed afterward...
Installation logfile
xo-server.service log
In this instance, the folder /etc/xo/xo-builds/xen-orchestra-202103181022 was not created and after reboot xo-server did not start.
journalctl -u xo-server -n 100
Reverting to /etc/xo/xo-builds/xen-orchestra-202103140300 brought it back online.