ronivay / XenOrchestraInstallerUpdater

Xen Orchestra install/update script
GNU General Public License v3.0
1.18k stars 189 forks source link

Add Rocky Linux 8 support #85

Closed ixs closed 3 years ago

ronivay commented 3 years ago

Hi,

Thanks for the effort. There's actually a reason why this wasn't yet implemented. I added AlmaLinux support recently and along with that, a possibility to skip OS check in script configuration file. This means one can force the script to run even on unsupported OS versions as long as it meets other requirements script is depending on.

The reason why i didn't start to add all RHEL derivates is that i don't have the possibility currently to test all of these actively. I'd like to keep the list of supported OS's relatively small.

I need to check if there's a feasible way to do automated testing with multiple OS versions. In that case adding more wouldn't be that big of a burden.

ixs commented 3 years ago

I saw that you added AL and I also saw the feature to disable checks... But for a working bistro, one should not need to disable checks and since https://github.com/nodesource/distributions/pull/1232 just merged, your installer works fine on Rocky Linux.

If you want to test different distros, maybe have a look at TravisCI or similar.