search

ronkeizer / vpc

R library to create visual predictive checks (VPC)
Other
36 stars 20 forks source link

Changes of the for loop in the "add_sim_index_number.R" #28

Closed MPislar closed 7 years ago

MPislar commented 8 years ago

Hi Ron,

We met at Uppsala Pharmacometric Summer School 2011. I guess you don't remember me, because there were plenty of us. Anyway, thank you for sharing your code, it is very useful for my work. Additionally it is also stimulating for improving or sharing additional code.

While I was doing "vpc_cens" I think I found an error at the "add_sim_index_number.R" code. I changed the code in the "for loop" and added 1 to the first row. Please check it out.

Best regards, Mitja

p.s. I'm a newbie at github so I hope that I've correctly pulled the changes of the code.

ronkeizer commented 7 years ago

hi Mitja, sorry for very late reply, i saw this pull request only now. Thanks for the pull request, I'm implementing this fix. I just made a small change to the code you supplied, so that's why I won't merge in your pull request directly but do it in a separate push. I've also added a test for this. Ron