search

ronkeizer / vpc

R library to create visual predictive checks (VPC)
Other
36 stars 20 forks source link

Changes to sim-indexing function #40

Closed TPreijers closed 7 years ago

TPreijers commented 7 years ago

Dear Ron, as a fan of your software, I'm using this code for generating vpc's a lot. However, when combining two datasets obtained from PsN::vpc the ID column was obviously not in the correct order for this function (add_sim_index_number) to obtain a column specifying the number of simulations. Therefore, the statistics were not calculated properly.

Proposed changes count how many times an ID is present in the dataset proposed to your vpc-function.

I hope this helps making your software more robust!

Cheers, Tim

codecov-io commented 7 years ago

Codecov Report

Merging #40 into master will decrease coverage by 0.02%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #40      +/-   ##
==========================================
- Coverage   60.97%   60.95%   -0.03%     
==========================================
  Files          26       26              
  Lines        1735     1734       -1     
==========================================
- Hits         1058     1057       -1     
  Misses        677      677
Impacted Files Coverage Δ
R/add_sim_index_number.R 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bafd11a...8a93ef0. Read the comment docs.