search

ronkeizer / vpc

R library to create visual predictive checks (VPC)
Other
36 stars 20 forks source link

Percentile based binning #41

Closed sebastianueckert closed 7 years ago

sebastianueckert commented 7 years ago

Made some changes to allow for a "general" VPC intended to be robust in regards to the amount of data and the particular design (see figure below). The changes include:

general-vpc

codecov-io commented 7 years ago

Codecov Report

Merging #41 into master will decrease coverage by 0.18%. The diff coverage is 45.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #41      +/-   ##
==========================================
- Coverage      61%   60.81%   -0.19%     
==========================================
  Files          26       26              
  Lines        1736     1748      +12     
==========================================
+ Hits         1059     1063       +4     
- Misses        677      685       +8
Impacted Files Coverage Δ
R/vpc.R 56.39% <100%> (+0.16%) :arrow_up:
R/binning.R 23.94% <16.66%> (-2.62%) :arrow_down:
R/plot_vpc.R 55.21% <71.42%> (+0.31%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 75149b6...1da3d4d. Read the comment docs.

sebastianueckert commented 7 years ago

Hi @ronkeizer, not sure why this build is failing. Is my code responsible for that? Seb

ronkeizer commented 7 years ago

hi Seb, no dont worry, most likely on my side. I'm doing some refactoring this week, will look at this again tomorrow or later this week. R

From: Sebastian Ueckert notifications@github.com<mailto:notifications@github.com> Sent: Tuesday, August 1, 2017 15:20 Subject: Re: [ronkeizer/vpc] Percentile based binning (#41) To: ronkeizer/vpc vpc@noreply.github.com<mailto:vpc@noreply.github.com> Cc: Ron Keizer ronkeizer@gmail.com<mailto:ronkeizer@gmail.com>, Mention mention@noreply.github.com<mailto:mention@noreply.github.com>

Hi @ronkeizerhttps://github.com/ronkeizer, not sure why this build is failing. Is my code responsible for that? Seb

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/ronkeizer/vpc/pull/41#issuecomment-319513589, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAO4URkbxxHZDiEjiGpnmHbq5lS0FOLKks5sT6SVgaJpZM4OeLr9.