search

ronkeizer / vpc

R library to create visual predictive checks (VPC)
Other
36 stars 20 forks source link

export quantile_cens ? #49

Closed smouksassi closed 5 years ago

smouksassi commented 6 years ago

Hi Ron quantile_cens is super useful would you please export it ?

ronkeizer commented 6 years ago

sure, will do

smouksassi commented 6 years ago

Thanks I am working with @olivierbarriere on https://github.com/smouksassi/ComputePI we want to bring in customized LLOQ by strata , customized binning by strata , bootstrapping the observed data to have CI on observed and so on. once it is exported we will avoid redefining it and import it from vpc !

ronkeizer commented 6 years ago

Sure. The function is now exported in the "dev" branch of the vpc package. I do have a few more things I want to update before I'll merge this branch into master and release to CRAN.

On Fri, Sep 7, 2018 at 11:13 AM Samer Mouksassi notifications@github.com wrote:

Thanks I am working with @olivierbarriere https://github.com/olivierbarriere on https://github.com/smouksassi/ComputePI we want to bring in customized LLOQ by strata , customized binning by strata , bootstrapping the observed data to have CI on observed and so on. once it is exported we will avoid redefining it and import it from vpc !

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/ronkeizer/vpc/issues/49#issuecomment-419522596, or mute the thread https://github.com/notifications/unsubscribe-auth/AAO4Ue3yEm-v71hkJofEP_UVj7ZhnNHFks5uYrcwgaJpZM4WZej- .

smouksassi commented 6 years ago

Thanks Ron can you please also allow to pass the ... so we can request the type of quantile we want ? e.g. try to mimick what PSN / Phoenix and or other tools do with their quantiles descriptions. In the ComputePI repo we are trying to support LLOQ column so you have study specific LLOQ and also different binning within strata. We are also relying on data.table for quicker computations.

ronkeizer commented 5 years ago

Sure, can you put in a PR for what you had in mind?

smouksassi commented 5 years ago

sure my colleagues just submitted one thank you !