ronkeizer / vpc

R library to create visual predictive checks (VPC)
Other
36 stars 20 forks source link

vpc_tte: bug in diagnostic messages #62

Closed philipdelff closed 4 years ago

philipdelff commented 4 years ago

A really annoying bug - seemingly very simple to fix. The bug gives an error.

In vpc_tte, a call to vpc:::msg fails due to what seems to be a typo. The second argument to msg is msg but should be verbose. This seems to happen three times in the function, the first time is in line 248.

msg takes a logical "verbose" argument but the msg function itself is passed - makes no sense. line 248: msg("Tip: with KMMC-type plots, binning of simulated data is recommended. See documentation for the 'bins' argument for more information.", msg)

The line gives: Error in if (verbose) { : argument is not interpretable as logical

If I skip this line, I get the expected output.