search

ronkeizer / vpc

R library to create visual predictive checks (VPC)
Other
36 stars 20 forks source link

Added scales to options #69

Closed sn248 closed 3 years ago

sn248 commented 4 years ago

Hi Ron

I have added the ability to define scales for x and y-axis to be free or fixed for your review. I think this feature could be useful when the x or y is markedly different between facets (e.g., between single and multiple dose groups).

I have added a test file (test-scales.R) and checked that the figure with scales = free_y option makes the y-axis scale to be free. I also checked that the package passes CRAN checks with these additions.

Thanks for the wonderful package! Satya

sn248 commented 4 years ago

@ronkeizer - Hi Ron, just checking if you had any thoughts on this PR to add ability to free scales for facets? I have regularly come across cases where I need different scales for facets. Thanks!

ronkeizer commented 3 years ago

hi Satyaprakash, sorry for not looking at this earlier. Thanks for suggesting the update, makes sense. Your PR seems fine, will merge it into master. I Am preparing for a resubmit to CRAN in next few days, so will try this new functionality as well.

sn248 commented 3 years ago

Totally understandable, thanks Ron! Please let me know if you find any issues.

Satya