ronnigaba / BoyumFoosballStats-2.0

2 stars 0 forks source link

Display gained/lost TrueSkill in Match history #39

Closed alexandrutatarciuc closed 11 months ago

alexandrutatarciuc commented 11 months ago

@ronnigaba I think it is really important to see how much true skill has a player received/lost based on the match. In this way, we can get a better overview on how the true skill works but also provide valuable insights

ronnigaba commented 11 months ago

That's not a bad idea! if nothing else, for 'debugging' it might be interesting to have the ability to check it out.

ronnigaba commented 11 months ago

@alexandrutatarciuc Also, this should go to the board instead - I've copied it there as well!

ronnigaba commented 11 months ago

@alexandrutatarciuc I tried adding them in a super simple way, not sure if you already started doing something, in which case it probably looks better than this xD I really think it gets a little too busy when it's placed like this, but yea, if nothing else, the logic is there now 📦

I also considered having a button or label just above the match score that could trigger a popover, which would show the scores. Either way, I think it was quite interesting

Image

alexandrutatarciuc commented 11 months ago

@ronnigaba That's really cool! I haven't started working on this, but I started thinking about how it could look. Based on the screenshot, I think that the trueskill takes too much attention and 'dilutes' the attention that should go towards the score of the match. I think that it would be nicer if we could place it in a MudChip

Here's a snippet: https://try.mudblazor.com/snippet/QucdFObSyCdWeHBv You could try and see which one looks better, I like the text variant.

Is there any reason why you moved the icons for the grey team to the start? I think it looks weird because they are misaligned because the names' lengths differ. I'd prefer the text to be misaligned rather that the icons.

ronnigaba commented 11 months ago

Ah, no - I was copy pasting some code around, so I think they got moved in the shuffle :p I had the same thoughts about it being too busy - but putting it in a cihp or sometihng similar might work out well! I'll try experimenting a little.

I really think seeing the numbers are quite interesting, I tried running against the live data, just to check.... There were some surprising learnings for sure - one match where Jeppe and I won against you and Paul, the TrueSkill change was literally 0 for all players xD Other matches, I've seen Paul gaining upwards of 40 points for winning a match

ronnigaba commented 11 months ago

image

alexandrutatarciuc commented 11 months ago

what about moving it to the other side (so that it's further away from the match score) (-14) Ronni 3 - 5 Jeppe (+14)

ronnigaba commented 11 months ago

I think that would make the alignment a little weird. I tried it out and indeed, I think it's a bit all over the place image

alexandrutatarciuc commented 11 months ago

Yeah, I agree... What about using badges instead? https://try.mudblazor.com/snippet/muGRbavpwikFGqsG