/arena enhancements - Githubissues

ronoaldo / ap-5r

Discord chatbot for Star Wars Galaxy of Heroes

Apache License 2.0

3 stars 2 forks source link

/arena enhancements #19

Closed druman55 closed 6 years ago

druman55 commented 6 years ago

/arena: o format updated, shortened Speed label and now it fits better. o Put the leader first on its own line, with a label. o Adjusted the name so the Stars, and Gear are shifted over and the name is more promenant. o Added a note if they dont say +more to make sure they know it exists!

screen_shot_2018-01-13_at_6_47_22_pm

/arena + more o Full labels for stats o Added Health + Protection total. o Added % signs after the Crit Dmg and Crit Chance.

screen_shot_2018-01-13_at_6_48_39_pm

ronoaldo commented 6 years ago

"Oh, It's beautiful" - Director Krennic about this update.

Nice work! I'll review the code soon to integrate :+1:

ronoaldo commented 6 years ago

Closes #18

ronoaldo commented 6 years ago

Did some testing on phone just to make sure output looks good as well, and it does:

Output of /arena:

Output of /arena

Output of /arena +more:

Output of /arena +more

ronoaldo commented 6 years ago

Code reviewed, LGTM!

:+1:

Merging into master, release follows!