search

ronomon / deduplication

Fast multi-threaded content-dependent chunking deduplication for Buffers in C++ with a reference implementation in Javascript. Ships with extensive tests, a fuzz test and a benchmark.
MIT License
71 stars 9 forks source link

Nodejs 12.0 support #6

Closed Smoozilla closed 4 years ago

Smoozilla commented 4 years ago

I'm no C++ pro hope this works, all tests passed

jorangreef commented 4 years ago

Thanks @Smoozilla

If you can give me a bit of time, I will rather upgrade to N-API directly. Then we can drop the NAN dependency entirely.

Smoozilla commented 4 years ago

Yes that sounds much better, thanks for all your contributions!

jorangreef commented 4 years ago

Thanks @Smoozilla you too.

Smoozilla commented 4 years ago

@jorangreef I'm considering attempting this, figured I'd give you a heads up in case you already were working on it

Smoozilla commented 4 years ago

@jorangreef I'm considering attempting this, figured I'd give you a heads up in case you already were working on it

I instead improved the rust port from your examples and have it running via wasm. Thank you for everything!