ronshnapp / MyPTV

MyPTV is an open source library designed for 3D particle Tracking (3D-PTV) measurements
MIT License
41 stars 15 forks source link

Complete OpenPTV-like example #4

Closed alexlib closed 2 years ago

alexlib commented 2 years ago

@ronshnapp it would be great if we consider a few things that will make all the adoption easier:

  1. one complete experiment example - e.g. https://github.com/openptv/test_cavity, along with the post-processing and plots, or maybe your jet on figshare
  2. we can do a zoom chat with you explaining to me all the analysis and all the insight and we record it as a tutorial for the followers
ronshnapp commented 2 years ago

Yes, examples are needed. I'll prepare synthetic images, and make a tutorial notebook. This will also be a good opportunity to sort out an easy workflow with the code.

alexlib commented 2 years ago

If you teach me, we both learn and record it.


From: Ron Shnapp @.> Sent: Saturday, April 9, 2022 2:09:14 AM To: ronshnapp/MyPTV @.> Cc: Alex Liberzon @.>; Author @.> Subject: Re: [ronshnapp/MyPTV] Complete OpenPTV-like example (Issue #4)

Yes, examples are needed. I'll prepare synthetic images, and make a tutorial notebook. This will also be a good opportunity to sort out an easy workflow with the code.

— Reply to this email directly, view it on GitHubhttps://github.com/ronshnapp/MyPTV/issues/4#issuecomment-1093456754, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAFWMZRNV5EBUIDAFL4JXFLVEC4BVANCNFSM5S5PZYAQ. You are receiving this because you authored the thread.Message ID: @.***>

alexlib commented 2 years ago

@ronshnapp I try to convert test_cavity into test_cavity_myptv folder but couldn't manage. Although apparently we use the same pinhole model from Maas, the f-number is very different (we count in tens, 20-100, probably millimetres) and you in thousands (not sure about units). Furthermore, some other parameters are probably different. If we could zoom over the calibration of one camera (from scratch) - it would help.

https://github.com/alexlib/test_cavity_myptv

ronshnapp commented 2 years ago

Yes, the models are slightly different. First, the "f" in MyPTV is the focal length in units of pixels, whereas it is in mm in the Mass model (that's why in OpenPTV you also need to put in the pixel size). Second, MyPTV uses the multimedia + radial + tangential + affine correction terms, while MyPTV uses a general 2nd order polynomial as the non-linear correction. All of this is explained in Sec.1.2 in the manual. Yes, let's do a Zoom - I may be able to do today. If not, we could do on Friday, or next week.