ronz94 / Steadfast

BSD 3-Clause "New" or "Revised" License
0 stars 1 forks source link

using package keyword for built in packages ?? #2

Closed Mr-Kumar-Abhishek closed 9 years ago

Mr-Kumar-Abhishek commented 9 years ago

regarding this commit --> https://github.com/ronz94/Steadfast/commit/73660ca929f828a948acf83febc5589b890340db

package javax.swing;

import java.awt.FlowLayout; //For defining the layout
import java.awt.event.ActionListener;
import java.io.*; // input-output operations
import java.net.HttpURLConnection; // making a connection
import java.net.URL; // in making a URL object
import javax.swing.JFrame; // in making Swing Frame
import javax.swing.JProgressBar; // in implementing Progress Bar
import java.awt.event.*;

We don't usually use package keyword for built in packages. Any special reason to do this ? Also if you are doing this, please remove all the imports of swing below it. And maybe also include all the files and libraries of swing package in the commit ? unless otherwise it doesn't makes sense.

ronz94 commented 9 years ago

without creating this package,'import javax.swing' was giving errors!

Mr-Kumar-Abhishek commented 9 years ago

It would be more helpfull for all of us if you just tell what are the errors rather than blankly telling , it is giving 'errors'.

Mr-Kumar-Abhishek commented 9 years ago

Also, if you think you need this as package javax.swing; then remove the imports having javax.swing

ronz94 commented 9 years ago

Removed unnecessary imports. https://github.com/ronz94/Steadfast/commit/44d7cb52d099f6fce80c95a2bf2f21e025778826