search

ronzeidman / ng2-ui-auth

an angular2 repository for authentication based on angular1's satellizer
MIT License
206 stars 64 forks source link

ES2015 export #105

Closed jochumdev closed 7 years ago

jochumdev commented 7 years ago

Hi,

today I got this working @pcdummy/angular-aot-es2015-rollup, its Angular 4.x with Tree-shaking (remove unneeded deps from the output).

This needs an ES2015 export in package.json (and ofc. the build of the files in releases) which is very good documented here.

Is there any interest in getting ES2015 exports into this library? If so i would make this happen with a PR.

jochumdev commented 7 years ago

A note: with tree-shaking Angular 4 compiles down to 355KiB

ronzeidman commented 7 years ago

I'd be happy to get a PR. Thanks!

aitboudad commented 7 years ago

That's something I've already done on my side see @ui-auth/core which follow Angular Package Format

aitboudad commented 7 years ago

I'll try to provide a PR once I have time but not soon :), https://github.com/dherges/ng-packagr may help

jochumdev commented 7 years ago

@aitboudad thanks for the tip on ng-packagr its great!

@ronzeidman Pull request is there.

ronzeidman commented 7 years ago

Thanks, didn't know about ng-packager!

aitboudad commented 7 years ago

Note: npm publish should be executed inside dist folder

jochumdev commented 7 years ago

travis will do that.