search

ronzeidman / ng2-ui-auth

an angular2 repository for authentication based on angular1's satellizer
MIT License
206 stars 64 forks source link

Google Login not working on Chrome for IOS #148

Open lafama opened 6 years ago

lafama commented 6 years ago

Am unable to login/signup via Google on Iphone/IOS. The pop opens but after authentication reverts to the pop up login page

ronzeidman commented 6 years ago

Sorry, I don't have a mac or an ios device so I can't test it, would appreciate help debugging this issue though

lafama commented 6 years ago

Hi, I finally managed to know whats happening. Pop-ups are not allowed on chrome ios, is there another way to authenticate other than using this


additionalUrlParams: {
 display: 'popup'}
ronzeidman commented 6 years ago

Currently no, I have a plan to create a redirect routes with no popups at all, but I don't have the time to implement it.

lafama commented 6 years ago

Hi, I figured out what the problem is

 cordova = cordova === null ? this.isCordovaApp() : cordova;

This code on chrome for IOS always returns true (makes it a cordova app ). I think we should have it set to false by default instead if null

ronzeidman commented 6 years ago

Interesting, I'll look into it soon

ronzeidman commented 5 years ago

I've changed the isCordovaApp logic a bit, maybe it works now, it's in the https://github.com/ronzeidman/ng2-ui-auth/tree/twitter_popup branch. Test it and if everything works fine I'll publish a new version.

ronzeidman commented 5 years ago

try version 9.2.1