search

roo-rb / roo-xls

Roo::Xls add support for legacy Excel file standards to Roo.
MIT License
82 stars 82 forks source link

Use Roo::Tempdir.make_tempdir instead of Roo::Base.make_tmpdir #29

Closed 545ch4 closed 7 years ago

545ch4 commented 7 years ago

Use Roo::Tempdir.make_tempdir instead of deprecated Roo::Base.make_tmpdir.

Fixes #28

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-1.3%) to 79.032% when pulling 131997894c37bea025d86ca7867b87c435ecbd6b on 545ch4:master into 6449b5de121420cb8981df876acf984b547d7703 on roo-rb:master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.4%) to 79.898% when pulling 7070c82beaaf68ab7c76f0a4ef1f48927bab930e on 545ch4:master into 6449b5de121420cb8981df876acf984b547d7703 on roo-rb:master.

wvengen commented 7 years ago

It seems this isn't yet working on all build configurations - some gems cannot be found. Was it a temporary network error? Would be useful to restart the build. Would love to see this merged.

Empact commented 7 years ago

Thanks, I went with #37 instead because it was simpler given the narrower use-case.

loren commented 7 years ago

Thank you for fixing this! Looking forward to the 1.1.0 gem.