search

roo-rb / roo-xls

Roo::Xls add support for legacy Excel file standards to Roo.
MIT License
82 stars 82 forks source link

Update for make_tmpdir deprecation #37

Closed kindjar closed 7 years ago

kindjar commented 7 years ago

Newer versions of the roo gem have marked the make_tmpdir method for deprecation. The deprecation notice suggests using make_tempdir in Roo::Tempdir, but that method is designed for using without a block (and the cleanup mechanism it uses isn't quite as robust as that used by Dir.mktmpdir). Since roo-xls only uses make_tmpdir in the block form, I opted to just directly use Dir.mktmpdir. This fixes the deprecation warnings otherwise sent to STDOUT by roo.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.4%) to 79.898% when pulling 825132e801742135ba809cac73fedaa9261b66ac on kindjar:master into 6449b5de121420cb8981df876acf984b547d7703 on roo-rb:master.