search

roo-rb / roo-xls

Roo::Xls add support for legacy Excel file standards to Roo.
MIT License
82 stars 82 forks source link

Bringing two tests back to life #48

Closed amatsuda closed 6 years ago

amatsuda commented 6 years ago

test_date_to_float_conversion and test_ruby_spreadsheet_formula_bug were not executed via rake test, because both test_excel_2003_xml.rb and test_roo_excel.rb defines the same test case TestRooExcel, and these two methods in the former file were overridden by the class in the latter file when being loaded via rake task.

This PR is an attempt to give another name to the test case in test_excel_2003_xml.rb, and makes all tests green.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+2.7%) to 83.69% when pulling ee2159f8f8b4243bd7669bba99c174fbcd9c1722 on amatsuda:dead_tests into 59ef3d6f80c0ac3aa0208c0daafd417c9e05bfa0 on roo-rb:master.

tgturner commented 6 years ago

Thanks @amatsuda !