Fix Excel2003: set namespace if not exist

roo-rb / roo-xls

Roo::Xls add support for legacy Excel file standards to Roo.

MIT License

82 stars 82 forks source link

Fix Excel2003: set namespace if not exist #56

Open Mihoid opened 5 years ago

Mihoid commented 5 years ago

Summary

Hi! This PR will help to open/read hard readable files Excel2003 without namespaces in workbook.

coveralls commented 5 years ago

Coverage increased (+0.5%) to 83.52% when pulling 569ba70d67fc19e32344c4f38aab81d2a467accc on evrone:fix/excel-2003-namespacing into 561e295335a0faddb4384021f748fa293882643b on roo-rb:master.

Mihoid commented 5 years ago

I will check what's wrong with coverage to fix it.

Mihoid commented 4 years ago

@chopraanmol1 Hi!🤝 Now PR looks good and test coverage fixed. 🙌🏼

Mihoid commented 4 years ago

@amatsuda @Empact @scottwillson Hi! 🙌🏼 Could you check this PR, please.

Thank you in advance!

Empact commented 4 years ago

Thanks for the fix - could you add a line to the test checking the namespace is as expected?