search

roo-rb / roo

Roo provides an interface to spreadsheets of several sorts.
MIT License
2.79k stars 501 forks source link

Use String Literal(frozen) over Constant lookup #477

Closed chopraanmol1 closed 5 years ago

chopraanmol1 commented 5 years ago

Summary

Because of a bug in ruby's frozen_string_literal implementation(https://bugs.ruby-lang.org/issues/15118) I used Constant lookup over string literal in this commit https://github.com/roo-rb/roo/pull/434/commits/699ff68306311600860227f5cff1f929d5e47698

Since this bug is both fixed and backported to ruby 2.4 & 2.5. We can now use the string literal over constant lookup.

Other Information

This change makes it easy to read code with no change in memory usage/allocation and performance improvement falls within noise.

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 94.082% when pulling d756d45e386972c556c6f1eebbe91f283bb11262 on chopraanmol1:use_string_literal_over_constant_lookup into b6d6479004d70e084bbe69fdf2f72bc0110b4a10 on roo-rb:master.

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 94.082% when pulling d756d45e386972c556c6f1eebbe91f283bb11262 on chopraanmol1:use_string_literal_over_constant_lookup into b6d6479004d70e084bbe69fdf2f72bc0110b4a10 on roo-rb:master.

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 94.082% when pulling d756d45e386972c556c6f1eebbe91f283bb11262 on chopraanmol1:use_string_literal_over_constant_lookup into b6d6479004d70e084bbe69fdf2f72bc0110b4a10 on roo-rb:master.

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 94.082% when pulling d756d45e386972c556c6f1eebbe91f283bb11262 on chopraanmol1:use_string_literal_over_constant_lookup into b6d6479004d70e084bbe69fdf2f72bc0110b4a10 on roo-rb:master.

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 94.082% when pulling d756d45e386972c556c6f1eebbe91f283bb11262 on chopraanmol1:use_string_literal_over_constant_lookup into b6d6479004d70e084bbe69fdf2f72bc0110b4a10 on roo-rb:master.