Add finalizer to weak instance cache

roo-rb / roo

Roo provides an interface to spreadsheets of several sorts.

MIT License

2.78k stars 502 forks source link

Add finalizer to weak instance cache #485

Closed chopraanmol1 closed 5 years ago

chopraanmol1 commented 5 years ago

Weak instance cache was added in https://github.com/roo-rb/roo/pull/456 .

Inspecting Roo::Excelx::Sheet and Roo::Excelx::Extractor's children's object is raising RefError.

This PR removes instance variable once respective object is GC'd

coveralls commented 5 years ago

Coverage increased (+0.02%) to 94.194% when pulling ddcf495c58e377fe21debb931740da1a86093f79 on chopraanmol1:add_finalizer_to_weak_instance_cache into aee36f26bdd280231c164f9c5ee1289441268314 on roo-rb:master.