Don't error when there are blank children elements.

roo-rb / roo

Roo provides an interface to spreadsheets of several sorts.

MIT License

2.79k stars 501 forks source link

Don't error when there are blank children elements. #487

Closed matzko closed 5 years ago

matzko commented 5 years ago

Summary

In the scenario represented by the fixture added in test/files/blank_children.xlsx and in newly-added spec, the file fails to parse

Other Information

New spec fails without fix to SheetDoc

Thanks for contributing to Roo!

coveralls commented 5 years ago

Coverage increased (+0.05%) to 94.249% when pulling ed09cd1ba28d83958503f88630605d46078d2596 on matzko:master into e7996b05bd2086824ad8a19f8001a21194c5ed61 on roo-rb:master.

coveralls commented 5 years ago

Coverage increased (+0.05%) to 94.249% when pulling ed09cd1ba28d83958503f88630605d46078d2596 on matzko:master into e7996b05bd2086824ad8a19f8001a21194c5ed61 on roo-rb:master.

coveralls commented 5 years ago

Coverage increased (+0.05%) to 94.249% when pulling ed09cd1ba28d83958503f88630605d46078d2596 on matzko:master into e7996b05bd2086824ad8a19f8001a21194c5ed61 on roo-rb:master.

chopraanmol1 commented 5 years ago

Thank you for submitting this PR.

pwim commented 5 years ago

I just ran into this. @chopraanmol1 could you release a 2.8.1 containing this fix?

chopraanmol1 commented 5 years ago

@pwim @matzko v2.8.1 is released

https://rubygems.org/gems/roo/versions/2.8.1

pwim commented 5 years ago

Awesome, thanks so much!