Skip extract_hyperlinks if not required

roo-rb / roo

Roo provides an interface to spreadsheets of several sorts.

MIT License

2.79k stars 501 forks source link

Skip extract_hyperlinks if not required #488

Closed chopraanmol1 closed 5 years ago

chopraanmol1 commented 5 years ago

Revisiting https://github.com/roo-rb/roo/pull/436

This Patch uses relationships data to determine if a sheet includes hyperlink or not.

As extract_hyperlinks loads the whole document in memory it is quite problematic for each_row_streaming. This patch tries to skip extract_hyperlinks when not required.

coveralls commented 5 years ago

Coverage increased (+0.06%) to 94.403% when pulling 4b1e6f09f54ca8f1388e2ea0f6ce81d155d76d44 on chopraanmol1:skip_extract_hyperlinks_if_not_required into faf1b437f777930c672342d27dcb48a1a9a6a21c on roo-rb:master.