search

roo-rb / roo

Roo provides an interface to spreadsheets of several sorts.
MIT License
2.79k stars 501 forks source link

Closes #491 add nil check for hyperlink['id'] #492

Closed weilandia closed 5 years ago

weilandia commented 5 years ago

[491-fix-bad-link-bug]

Summary

Closes #491

coveralls commented 5 years ago

Coverage Status

Coverage decreased (-0.04%) to 94.301% when pulling 0479c16d0c7ca03be19f0876ec1a003fcc4f36ed on weilandia:491-fix-bad-link-bug into 4acaef8104be0368d8b9e89365816b8cf281cff7 on roo-rb:master.

weilandia commented 5 years ago

Thanks for the review @chopraanmol1 -- I made your suggested changes so let me know if anything else needs to be done.

It would be awesome 🙏 to get a version bump for this as we're using a gem that depends on roo and we're getting this error a few times a day when parsing incoming files.

Thanks again!

chopraanmol1 commented 5 years ago

@weilandia I've released a new version.

https://rubygems.org/gems/roo/versions/2.8.2