Fix warnings caused by Ruby 2.7 update

roo-rb / roo

Roo provides an interface to spreadsheets of several sorts.

MIT License

2.78k stars 503 forks source link

Fix warnings caused by Ruby 2.7 update #530

Closed taichi-ishitani closed 4 years ago

taichi-ishitani commented 4 years ago

Summary

Fixed following warnings caused by Ruby 2.7 update.

Using the last argument as keyword parameters is deprecated
calling URI.open via Kernel#open is deprecated, call URI.open directly or use URI#open
URI.escape is obsolete

coveralls commented 4 years ago

Coverage increased (+0.05%) to 94.444% when pulling 9e1e002f3a6f303fa17647b4456f95f29e273d2a on taichi-ishitani:ruby_27_support into 221750b72671b96321ac81ca11d5d9abc9267aef on roo-rb:master.

taichi-ishitani commented 4 years ago

Cam anyone review my PR?

taichi-ishitani commented 4 years ago

Hi @chopraanmol1 , @simonoff , Could you please review my PR? Thank you for your time.

jonspalmer commented 4 years ago

Adding my 👍 to get this reviewed and release. It a blocker for folks trying to upgrade to Ruby 2.7.x

jonspalmer commented 4 years ago

Maybe we should just drop Ruby 2.3 and 2.4 given they're both end of support.

simonoff commented 4 years ago

@jonspalmer would be great!

weilandia commented 4 years ago

Can we get this published?? 🙏