I'm open to suggestions on how the test is structured. I wanted to setup the tests in a way that made it easier to write future tests against various cell xml configurations. I use this gem at work with customer data so generating spreadsheets that reproduce issues is difficult due to having to scrub the data. I can easily unzip the spreadsheets to identify 'interesting' xml tags.
Ideally, I would have tested cell_from_xml to avoid dealing with arrays but I didn't want to change the visibility of that method for this bug fix.
I would be interested in trying to restructure the SheetDoc class so it's easier to test some of core functionality of methods like cell_from_xml and create_cell_from_value in the future. Is that something that would be of interest?
Summary
This is an attempt to fix https://github.com/roo-rb/roo/issues/541.
Other Information
I'm open to suggestions on how the test is structured. I wanted to setup the tests in a way that made it easier to write future tests against various cell xml configurations. I use this gem at work with customer data so generating spreadsheets that reproduce issues is difficult due to having to scrub the data. I can easily unzip the spreadsheets to identify 'interesting' xml tags.
Ideally, I would have tested
cell_from_xmlto avoid dealing with arrays but I didn't want to change the visibility of that method for this bug fix.I would be interested in trying to restructure the SheetDoc class so it's easier to test some of core functionality of methods like
cell_from_xmlandcreate_cell_from_valuein the future. Is that something that would be of interest?