search

roo-rb / roo

Roo provides an interface to spreadsheets of several sorts.
MIT License
2.78k stars 503 forks source link

Fix issue with spreadsheets containing filters #543

Closed coorasse closed 1 year ago

coorasse commented 3 years ago

This PR tackles and closes roo-rb#533 and roo-rb#276

md5 commented 1 year ago

@kakubin any chance you could take a look at this PR? I'm in the process of updating one of our apps and saw that we're maintaining an internal fork of this gem that has nearly identical fix to this one.

Apologies if you're not the right person to ping, but I see that you've merged some recent PRs.

kakubin commented 1 year ago

I've been removed my authority, so I honestly don't know what my role is.

kakubin commented 1 year ago

@patrickkulling Would you be willing to review it too?

patrickkulling commented 1 year ago

I will have a look later today

md5 commented 1 year ago

Thanks @patrickkulling! It looks like there are a fair number of changes post-v2.9.0 that would be helpful to get into a v2.10.0 release. Any chance that is in the works?

patrickkulling commented 1 year ago

@md5 There is one additional PR that I would like to see back at least but I agree that we should be planning to release a new version of roo soon.

I will try to figure out how that has been done in the past.