Closed dcangulo closed 2 years ago
Seconding the need for this fix now that Ruby 3.0 is released
It seems master is compatible. Maybe release a new version?
any chances of releasing update soon?
Same problem here!
Thanks for fixing this issue on the master branch! However could you please release a new bugfix version?
@larskanis please pardon my ignorance, but where is the fix 'on the master branch' that you are mentioning? At this moment I can use anything, to be honest, this issue is impacting live services of my application :(
@uzian Commit https://github.com/roo-rb/roo/commit/22d99302b34c5a38acfc2806daaf94a449f1e821 fixes compatibility with Ruby-3.0.
In case this helps someone, you are able to use the patched code by fetching a specific commit rather than a released gem:
# Until Roo releases a new version containing a fix for Ruby 2.7 deprecation warnings,
# we need to fetch the source directly from GitHub. (https://github.com/roo-rb/roo)
gem "roo", git: "https://github.com/roo-rb/roo.git", ref: "868d4ea419cf393c9d8832838d96c82e47116d2f"
In case this helps someone, you are able to use the patched code by fetching a specific commit rather than a released gem:
# Until Roo releases a new version containing a fix for Ruby 2.7 deprecation warnings, # we need to fetch the source directly from GitHub. (https://github.com/roo-rb/roo) gem "roo", git: "https://github.com/roo-rb/roo.git", ref: "868d4ea419cf393c9d8832838d96c82e47116d2f"
Thank you Erik, but how can I add this commit version of Roo (or the master one) to the global gem system with the unix gem
command line tool? (from Ruby-3.0.2)
-- Maurice
@diam I've never done that, but I'd try either to build the gem yourself and install it or use the specific_install gem.
Thanks Erik, I didn't know the specific_install
gem extension!
So the following commands solved the problem:
gem uninstall roo
gem install specific_install
gem specific_install -l https://github.com/roo-rb/roo.git -r 868d4
-- Maurice
Edit: but I don't know what would happen if I did a gem update
or something like that. So an update to the official gem would be welcome ;-)
This gem is a dependency of other gems like simple-spreadsheet so a proper release is in order.
@simonoff Any chance you could initiate a patchlevel release containing the fix mentioned above? It's sad to see this useful have test suites turn red for so many – even more so since the fix will soon celebrate it's first anniversary. Thanks a bunch!
Wow. Let me check please. I'm sorry I'm little bit get our due to the situation in Ukraine from where i'm originally.
OT: I feel you, been working all week on our little studio to prep it for war refugees from UA.
@svoop Done!
@simonoff Thanks a lot... and мир Україні зараз!
Steps to reproduce
test.csv
test.rb
Issue
Works with Ruby 2.7.2.
Error with Ruby 3.0.0 Preview 1
System configuration
Roo version:
Ruby version:
ruby 2.7.2p137 (2020-10-01 revision 5445e04352) [x86_64-darwin19]
(works)ruby 3.0.0preview1 (2020-09-25 master 0096d2b895) [x86_64-darwin19]
(doesn't work)