Fix Roo::Base#each_with_pagename degraded at #576

roo-rb / roo

Roo provides an interface to spreadsheets of several sorts.

MIT License

2.78k stars 501 forks source link

Fix Roo::Base#each_with_pagename degraded at #576 #584

Closed kakubin closed 10 months ago

kakubin commented 1 year ago

Summary

Roo::Excel#each_with_pagename broken at this change. It intended to add feature to return Enumerator if block is not given, on the other side, it should keep previous behavior. In fact, the latter was not followed.

This PR fix the behavior when block given.

broksonic21 commented 1 year ago

Thanks! appreciate it.

Urist-McUristurister commented 1 year ago

Any ETA on merging this one?.. It's been pending for a while...

jbakerdev commented 1 year ago

Bump

kakubin commented 10 months ago

@patrickkulling could you take a look at this please?

kakubin commented 10 months ago

@patrickkulling thank you