search

roo-rb / roo

Roo provides an interface to spreadsheets of several sorts.
MIT License
2.78k stars 501 forks source link

Avoid warnings in Ruby 3.1 when finalizer is called twice [fix #585] #586

Closed owst closed 1 year ago

owst commented 1 year ago

Fixes #585

owst commented 1 year ago

@patrickkulling any chance you could take a look at this? It's causing quite a lot of noise in our development environments

patrickkulling commented 1 year ago

@kakubin can you have a look at this please? I am currently on vacation for a while

owst commented 1 year ago

@kakubin - have you had a chance to look at this PR? Hopefully it's uncontroversial!

owst commented 1 year ago

Thanks @kakubin! Do you know when this can be merged (and released)?

owst commented 1 year ago

Ping @kakubin or @patrickkulling - it would be great to get this merged and released if we can!

owst commented 1 year ago

Another ping at @kakubin and @patrickkulling - is there a plan to get this merged (and released)?

kakubin commented 1 year ago

@patrickkulling I don't have the authority to merge, so I would like to ask you

patrickkulling commented 1 year ago

@owst sorry for the long delay. it's merged but I am lacking rights to create a patch release.

ermolaev commented 11 months ago

@simonoff you can push new version with this patch to rubygems?