roo-rb / roo

Roo provides an interface to spreadsheets of several sorts.
MIT License
2.78k stars 502 forks source link

[Doc] Iterate through each sheet with "each_with_pagename" not working anymore #587

Open cyrilsuzat opened 1 year ago

cyrilsuzat commented 1 year ago

Steps to reproduce

xlsx = Roo::Spreadsheet.open('./new_prices.xlsx')

xlsx.each_with_pagename do |name, sheet|
  p name
end

=> #<Enumerator: #<Enumerator::Generator:0x0000000107d6b188>:each>

Issue

If think the method each_with_pagename has changed and the doc should be adapted accordingly, with something like this :

# Iterate through each sheet
xlsx.sheets.each do |name|
  sheet = xlsx.sheet(name)
  p name
end
fonji commented 1 year ago

There are two open PRs that attemps to fix this https://github.com/roo-rb/roo/pull/588 and https://github.com/roo-rb/roo/pull/584 but no news…

fonji commented 11 months ago

As #584 is merged, I guess this is just waiting for a new release