rooch-network / rooch

VApp Container with Move Language
https://rooch.network
Apache License 2.0
128 stars 54 forks source link

[Bitcoin] Handle coinbase transaction for Ord #1538

Closed baichuan3 closed 1 month ago

baichuan3 commented 1 month ago

Summary

Process the coinbase transactions in the block, pay the block reward + all transaction fees to the miners, and process the Ord Satpoint transfer.

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **rooch** | ⬜️ Ignored ([Inspect](https://vercel.com/rooch/rooch/5tTiX6Thkq9BLKBcDfv9REJ87f8U)) | [Visit Preview](https://rooch-git-handlecoinbase-rooch.vercel.app) | | Apr 8, 2024 10:16am |
adshao commented 1 month ago

This pr looks good to me.

However, in my opinion, there are still some issues about the inscription code:

baichuan3 commented 1 month ago
  • inscriptions Can you describe the specific differences in inscribing new inscriptions?
adshao commented 1 month ago
  • inscriptions Can you describe the specific differences in inscribing new inscriptions?

For example, is_seperate_outputs is unnecessary here, offset should be determined by pointer

jolestar commented 1 month ago
  • inscriptions Can you describe the specific differences in inscribing new inscriptions?

For example, is_seperate_outputs is unnecessary here, offset should be determined by pointer

is_separate_outputs need to be removed after SatPoint implemention.