search

rooch-network / rooch

VApp Container with Move Language
https://rooch.network
Apache License 2.0
128 stars 54 forks source link

[gh-1554] upgrade rust version and fix syntax errors. #1555

Closed feliciss closed 1 month ago

feliciss commented 1 month ago

Summary

Upgrade rust version and fix errors.

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **rooch** | ⬜️ Ignored ([Inspect](https://vercel.com/rooch/rooch/CbFAjSaHbsrybLo2Md5xuhrDBR1u)) | [Visit Preview](https://rooch-git-fork-feliciss-1554-rooch.vercel.app) | | Apr 15, 2024 11:36am |
feliciss commented 1 month ago

Help debug GitHub CI. @jolestar @popcnt1 @yourmoonlight

jolestar commented 1 month ago

It seems like Rustup does not support it. 

profile = "minimal"
channel = "stable-2023-11-16" # https://blog.rust-lang.org/2023/11/16/Rust-1.74.0.html --component rustfmt --component clippy
error: error: invalid value '[toolchain]
profile = "minimal"
channel = "stable-2023-11-16" # https://blog.rust-lang.org/2023/11/16/Rust-1.74.0.html' for '<toolchain>...': invalid toolchain name: '[toolchain]
profile = "minimal"
channel = "stable-2023-11-16" # https://blog.rust-lang.org/2023/11/16/Rust-1.74.0.html'

For more information, try '--help'.
: invalid toolchain name: '[toolchain]
profile = "minimal"
channel = "stable-2023-11-16" # https://blog.rust-lang.org/2023/11/16/Rust-1.74.0.html'
Error: The process '/home/runner/.cargo/bin/rustup' failed with exit code 1
popcnt1 commented 1 month ago

Help debug GitHub CI. @jolestar @popcnt-subodhi @yourmoonlight

Will work on it soon.

@jolestar Let me figure it out, take a break

popcnt1 commented 1 month ago

@feliciss

try to remove inputs in .github/actions/rust-setup/action.yaml in action-rs(https://github.com/marketplace/actions/rust-toolchain)

reason:

CI rely on actions-rs/toolchain to install rust toolchain, and " Input has higher priority, so if you are want to use toolchain file, you need to remove the input from the workflow file."

feliciss commented 1 month ago
  1. default profile to install toolchain
  2. fix input in rust-setup/action.yaml
  3. try 1.75.0? (it's a good time to upgrade rust)

I tried to remove action.yaml but there still has issue.

popcnt1 commented 1 month ago
  1. default profile to install toolchain
  2. fix input in rust-setup/action.yaml
  3. try 1.75.0? (it's a good time to upgrade rust)

I tried to remove action.yaml but there still has issue.

  1. check_build_test(which you failed workflow) run on main branch (you could check it in the source code)
  2. you could create a new PR to just modify .github/actions/rust-setup/action.yaml, and keep 1.74.0 firstly for checking new toolchain config works. Then another PR upgrade the rust version
feliciss commented 1 month ago
  1. default profile to install toolchain
  2. fix input in rust-setup/action.yaml
  3. try 1.75.0? (it's a good time to upgrade rust)

I tried to remove action.yaml but there still has issue.

  1. check_build_test(which you failed workflow) run on main branch (you could check it in the source code)
  2. you could create a new PR to just modify .github/actions/rust-setup/action.yaml, and keep 1.74.0 firstly for checking new toolchain config works. Then another PR upgrade the rust version

I made this PR to just upgrading rust version. The rust-toolchain file format remains the same to be resolved.