rooch-network / rooch

VApp Container with Move Language for Bitcoin ecosystem
https://rooch.network
Apache License 2.0
162 stars 85 forks source link

[Move] [break] Support TypeTag and StructTag to canonical string with prefix #2515

Closed baichuan3 closed 2 months ago

baichuan3 commented 2 months ago

Summary

  1. Support TypeTag, StructTag and AccountAddress to canonical string with prefix 0x.
  2. Unify the canonical and non-canonical string format to 0x00000000000000000000000000000001::string::String or 0x0000000000000000000000000000000a::module_name1::type_name1<0x0000000000000000000000000000000a::module_name2::type_name2<u64>>

Other impacts include possible break of SDK and front-end applications, please confirm @wow-sven

  1. The to_canonical_string() method of TypeTag, StructTag and AccountAddress returns a prefix containing 0x by default
  2. The generated type name contains the 0x prefix
  3. Generation of NamedObjectID
  4. Generation of some field keys
vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rooch-portal ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 29, 2024 0:17am
rooch-portal-v2.1 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 29, 2024 0:17am
1 Skipped Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **rooch** | ⬜️ Ignored ([Inspect](https://vercel.com/rooch/rooch/Bm85mTYJDayVGitCCv2ULE6N8Gcu)) | [Visit Preview](https://rooch-git-typetagprefix-rooch.vercel.app) | | Aug 29, 2024 0:17am |
github-actions[bot] commented 2 months ago

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files