search

rooch-network / rooch

VApp Container with Move Language for Bitcoin ecosystem
https://rooch.network
Apache License 2.0
162 stars 85 forks source link

[bitseed] Implement bitseed merge #2658

Closed jolestar closed 1 month ago

jolestar commented 1 month ago

Summary

Following #2635, please review #2635 first.

  1. [bitcoin-move] Do not freeze the Inscription Object when burned; transfer it to the bitcoin_move address.
  2. [bitseed] Migrate the bitseed runner process into the inscribe_factory module and remove it from examples.
  3. [bitseed] Refactor inscribe merge, put the burn inputs after the reveal inputs.
  4. [bitseed] Implement validate logic for bitseed merge.

TODO:

  1. Implement birdseed split validation.
  2. Refactor the inscribe_factory, make code clear.
vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rooch-portal ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 21, 2024 2:57pm
rooch-portal-v2.1 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 21, 2024 2:57pm
1 Skipped Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **rooch** | ⬜️ Ignored ([Inspect](https://vercel.com/rooch/rooch/4Snj5EGiupucghwT3BUtjizhEWbx)) | [Visit Preview](https://rooch-git-bitseedmerge-rooch.vercel.app) | | Sep 21, 2024 2:57pm |
github-actions[bot] commented 1 month ago

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

yubing744 commented 1 month ago

image

Now the latest Merge data stream becomes like this?

yubing744 commented 1 month ago

It seems that if the total number of SFT inscriptions burned in a transaction is greater than or equal to the total number of SFT inscriptions generated, then this operation should be valid. If so, the implementation of Merge and Split is the same.